search

facebookarchive / react-native-fbsdk

A React Native wrapper around the Facebook SDKs for Android and iOS. Provides access to Facebook login, sharing, graph requests, app events etc.
https://developers.facebook.com/docs/react-native
Other
2.99k stars 906 forks source link

Update underlying SDK versions #811

Closed mikehardy closed 4 years ago

mikehardy commented 4 years ago

Allow facebook-android-sdk to be 7.0 through 8.x (should get 8.2.0 now) Use facebook-ios-sdk 8.1 (current stable)

Fixes #798

Test Plan:

I updated the underlying SDKs, and I have integrated changes that do the same (via patch-package) into my work app. Everything seems to work, but I do not use all of the SDK functionality.

I would assume (dangerous) if it compiles okay that it should be fine, if the APIs and symbols defined upstream did not change meaning

mikehardy commented 4 years ago

@janicduplessis this is probably good for review now, you appear to be the merger in this module? Cheers :-)

janicduplessis commented 4 years ago

Hey thanks @mikehardy , I think these changes are already in https://github.com/facebook/react-native-fbsdk/pull/804 which we should be able to merge soon.

mikehardy commented 4 years ago

@janicduplessis I think you are right but I noted on that PR that there are two things worth changing perhaps https://github.com/facebook/react-native-fbsdk/pull/804/files?file-filters%5B%5D=.gradle&file-filters%5B%5D=.h&file-filters%5B%5D=.java&file-filters%5B%5D=.m&file-filters%5B%5D=.podspec#r521603372

I'll close this in preference to that one :-)

janicduplessis commented 4 years ago

Thanks, perfect!