search

facebookarchive / react-native-fbsdk

A React Native wrapper around the Facebook SDKs for Android and iOS. Provides access to Facebook login, sharing, graph requests, app events etc.
https://developers.facebook.com/docs/react-native
Other
2.99k stars 909 forks source link

Change the Facebook SDK to version 9 #833

Open zhantx opened 3 years ago

zhantx commented 3 years ago

Change the Facebook SDK to version 9. Given there is no breaking changes, all API should work as previous.

Fixes #832

facebook-github-bot commented 3 years ago

Hi @zhantx!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Fl0p commented 3 years ago

+1

Fl0p commented 3 years ago

@zhantx please hit this CLA https://github.com/facebook/react-native-fbsdk/pull/833/checks?check_run_id=1831428073

zhantx commented 3 years ago

@zhantx please hit this CLA https://github.com/facebook/react-native-fbsdk/pull/833/checks?check_run_id=1831428073

Finished

facebook-github-bot commented 3 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

therealchiko commented 3 years ago

thanks for all the incredible work with regards to fb sdk 9.0 @zhantx. Does anyone know when this will get merged and the next release published?

Fl0p commented 3 years ago

Waiting for merge...

rnike commented 3 years ago

Please take a full review of the conversations in #832, it seems like it will never be merged because Facebook is not going to maintain this package anymore.

For anyone who is waiting for this to be merged, I would recommend just fork or use patch-package.

Or you can just add it from our forked repo, our repo include commits from this PR. (Thanks @zhantx)

To install: yarn add VeryBuy/react-native-fbsdk#release/3.0.1

There are also two changes we have done:

criss93 commented 3 years ago

@janicduplessis can you review this? We need the SDK upgrade on this package, please!

Kamal-Walia commented 3 years ago

Please let us know when this is going to merge in the package? Till the time I've forked this package and included this PR. https://github.com/Kamal-Walia/react-native-fbsdk