search

facebookarchive / rebound

A Java library that models spring dynamics and adds real world physics to your app.
http://facebook.github.io/rebound/
Other
5.44k stars 818 forks source link

Update the gradle version and new JDK issue #77

Open adilek opened 8 years ago

adilek commented 8 years ago

It was not able to compile with new gradle version and also JDK 8. So the gradle version is updated and lint issue is solved to remove the gradle issue.

With this patch it is possible to compile with JDK8 also (however it is uses JDK7 mode because of com.facebook.rebound.SynchronousLooper)

ghost commented 8 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

facebook-github-bot commented 8 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

danielgomezrico commented 7 years ago

any update on this?

adilek commented 7 years ago

Not yet. ))) No one wants to merge it.

zhiqizhu commented 7 years ago

Can anyone merge this?

knightkill commented 7 years ago

It's about to be year to this PR... Don't know what they are so much testing about in just 4 files. Please guys merge this so people can use this wonderful piece of code :)

adilek commented 7 years ago

New versions of gradle were released )))))))

knightkill commented 7 years ago

But still gradle version is 1.2.3 which is not supported by current Android Studio version.