search

facebookarchive / redux-react-hook

React Hook for accessing state and dispatch from a Redux store
MIT License
2.16k stars 103 forks source link

ReactDOM peer dependency #42

Closed tom-drake closed 5 years ago

tom-drake commented 5 years ago

Does ReactDOM need to be a peer dependency for this? I can only see it being used in a test file. I've been using this library in a react-native app and so far it has been fine apart from the npm install console warning which I just ignore for now.

ianobermiller commented 5 years ago

Good catch, probably not. Would you like to send a PR?

On Tue, Mar 12, 2019 at 6:15 PM Thomas Drake notifications@github.com wrote:

Does ReactDOM need to be a peer dependency for this? I can only see it being used in a test file. I've been using this library in a react-native app and so far it has been fine apart from the npm install console warning which I just ignore for now.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/facebookincubator/redux-react-hook/issues/42, or mute the thread https://github.com/notifications/unsubscribe-auth/AA2zixdXBapkK05B2mpYO1n0mJxie0bmks5vWFETgaJpZM4bsMGa .

ianobermiller commented 5 years ago

Fixed in 7d6dfb770c99a3df8f76cdc2800f31d3ae55ba5e and published as v3.2.1

tom-drake commented 5 years ago

Thanks for getting that sorted. I would have got a PR in but have been a little busy :(

ianobermiller commented 5 years ago

No problem, it had been a while since I touched the project, too.

On Thu, Mar 14, 2019 at 3:22 AM Thomas Drake notifications@github.com wrote:

Thanks for getting that sorted. I would have got a PR in but have been a little busy :(

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/facebookincubator/redux-react-hook/issues/42#issuecomment-472789887, or mute the thread https://github.com/notifications/unsubscribe-auth/AA2zi_RNPy4NyRrnasXNrHhAthtaa7npks5vWiLFgaJpZM4bsMGa .