search

facebookarchive / rocks-strata

Other
133 stars 24 forks source link

Use S3 Server Side Encryption in Strata #19

Open geoffbonneau opened 7 years ago

geoffbonneau commented 7 years ago

I am not very familiar with Go, so I apologize if this is a silly question. Is there a way to have Strata upload files to S3 with the SSE flag/options enabled?

igorcanadi commented 7 years ago

Yeah, I think so. We use github.com/AdRoll/goamz library to access S3 and that library does expose the SSE option: https://github.com/AdRoll/goamz/blob/master/s3/s3.go#L63

So you'd just have to hook it up with our API here: https://github.com/facebookgo/rocks-strata/blob/master/strata/s3storage/storage.go#L59

Feel free to submit the pull request!

geoffbonneau commented 7 years ago

Thanks for the pointers, I will take a swing at it.