Closed AdallomRoy closed 6 years ago
Not sure why this PR fails - it works for me...
Thanks
Not sure why this PR fails - it works for me...
As you mentioned, the change that caused minio to break your build is https://github.com/minio/minio-go/commit/f98a667ab5d283564aa82ac0aec08dcf34b4e5bb#diff-178b7853ff9d7acbcc6b327d8723026e, which is from September 19. That change hasn't yet made it into a minio release (https://github.com/minio/minio-go/releases). Maybe Travis CI is using the latest released version of minio while you're using master.
If you don't mind, I'll wait until minio releases the change, then I'll re-run CI and merge.
@AGFeldman
how long is the ETA for this merge ?
strata doesn't compile any more
My go version is go1.9.2 linux/amd64
with env
OR if possible, lets push the builds under release, thanks :bowing_man:
Anyone want to update this PR for https://github.com/minio/minio-go/pull/821 ? cc @AdallomRoy
This PR originally addressed https://github.com/minio/minio-go/pull/811, but the API changed again in 821.
All these API changes were released in https://github.com/minio/minio-go/releases/tag/4.0.0
Still lot to learn, I am able to get it compiled with these changes, should I create a new PR ?
Thanks all, should be fixed with #37
This commit: https://github.com/minio/minio-go/commit/f98a667ab5d283564aa82ac0aec08dcf34b4e5bb broke rocks-strata (Doesn't compile). This is a PR to use the new interface.