facebookarchive / rocks-strata

Other
133 stars 24 forks source link

Fix minio PutObject #36

Closed AdallomRoy closed 6 years ago

AdallomRoy commented 6 years ago

This commit: https://github.com/minio/minio-go/commit/f98a667ab5d283564aa82ac0aec08dcf34b4e5bb broke rocks-strata (Doesn't compile). This is a PR to use the new interface.

AdallomRoy commented 6 years ago

Not sure why this PR fails - it works for me...

AGFeldman commented 6 years ago

Thanks

Not sure why this PR fails - it works for me...

As you mentioned, the change that caused minio to break your build is https://github.com/minio/minio-go/commit/f98a667ab5d283564aa82ac0aec08dcf34b4e5bb#diff-178b7853ff9d7acbcc6b327d8723026e, which is from September 19. That change hasn't yet made it into a minio release (https://github.com/minio/minio-go/releases). Maybe Travis CI is using the latest released version of minio while you're using master.

If you don't mind, I'll wait until minio releases the change, then I'll re-run CI and merge.

thapakazi commented 6 years ago

@AGFeldman how long is the ETA for this merge ? strata doesn't compile any more screenshot-20171127-13 29 06

My go version is go1.9.2 linux/amd64 with env

``` go env [ GOARCH="amd64" GOBIN="~/.go/bin" GOEXE="" GOHOSTARCH="amd64" GOHOSTOS="linux" GOOS="linux" GOPATH="~/.go" GORACE="" GOROOT="/usr/lib/go" GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64" GCCGO="gccgo" CC="gcc" GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build191252707=/tmp/go-build -gno-record-gcc-switches" CXX="g++" CGO_ENABLED="1" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" ```

OR if possible, lets push the builds under release, thanks :bowing_man:

AGFeldman commented 6 years ago

Anyone want to update this PR for https://github.com/minio/minio-go/pull/821 ? cc @AdallomRoy

This PR originally addressed https://github.com/minio/minio-go/pull/811, but the API changed again in 821.

All these API changes were released in https://github.com/minio/minio-go/releases/tag/4.0.0

thapakazi commented 6 years ago

Still lot to learn, I am able to get it compiled with these changes, should I create a new PR ? screenshot-20171128-07 33 40

AGFeldman commented 6 years ago

Thanks all, should be fixed with #37