search

facebookarchive / shimmer-android

An easy, flexible way to add a shimmering effect to any view in an Android app.
http://facebook.github.io/shimmer-android/
Other
5.31k stars 698 forks source link

expand ShimmerDrawable api to make rounded corners #115

Closed qoswa closed 3 years ago

qoswa commented 3 years ago

Addressing issue https://github.com/facebook/shimmer-android/issues/84

Main use case is using ShimmerDrawable as Glide placeholder It is already possible, but without possibility to make rounded corners

facebook-github-bot commented 3 years ago

Hi @qoswa!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 3 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

qoswa commented 3 years ago

Hi @xiphirx Please, take a look at this pr when you have time to