search

facebookarchive / shimmer-android

An easy, flexible way to add a shimmering effect to any view in an Android app.
http://facebook.github.io/shimmer-android/
Other
5.32k stars 697 forks source link

Moving hardcoded text into strings.xml #49

Closed sonutiwari closed 6 years ago

sonutiwari commented 6 years ago

Moving hardcoded text into strings.xml Issue 45

sonutiwari commented 6 years ago

The first change wasn't made by me, so it seems I accepted intended action somewhere in the process.

For indentation, actually its a 4 space indentation but I think I need to use 8 space indentation now.

On Thu 19 Apr, 2018, 6:11 AM Hilal Alsibai, notifications@github.com wrote:

@xiphirx requested changes on this pull request.

Great! There are just some formatting issues with the changes and one unrelated change that needs to be split into a different pull request.

Also a quick tip, if you want to link a PR to a issue, you can simply include something like "fixes #45 https://github.com/facebook/shimmer-android/issues/45" in the description, and GitHub will auto-link it for you.

In gradle/wrapper/gradle-wrapper.properties https://github.com/facebook/shimmer-android/pull/49#discussion_r182607491 :

distributionBase=GRADLE_USER_HOME distributionPath=wrapper/dists zipStoreBase=GRADLE_USER_HOME zipStorePath=wrapper/dists -distributionUrl=https\://services.gradle.org/distributions/gradle-4.5.1-bin.zip +distributionUrl=https\://services.gradle.org/distributions/gradle-4.5.1-all.zip

Why is this change included in this pull request?

In sample/src/main/res/layout/main.xml https://github.com/facebook/shimmer-android/pull/49#discussion_r182607635 :

<com.facebook.shimmer.ShimmerFrameLayout

  • android:id="@+id/shimmer_view_container"
  • android:layout_width="wrap_content"
  • android:layout_height="wrap_content"
  • android:layout_gravity="center"
  • app:shimmer_duration="1000">
  • android:id="@+id/shimmer_view_container"
  • android:layout_width="wrap_content"
  • android:layout_height="wrap_content"
  • android:layout_gravity="center"
  • app:shimmer_duration="1000"

Why were parts of this file reformatted while the rest wasnt? Can we keep the previous format?

In sample/src/main/res/values/strings.xml https://github.com/facebook/shimmer-android/pull/49#discussion_r182607959 :

@@ -1,4 +1,13 @@ <?xml version="1.0" encoding="utf-8"?>

Shimmer + Facebook’s mission is to give people the power to build community

The formatting here is off, seems like you're using 2 space indents. This project has 4 space indents for xml files.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/facebook/shimmer-android/pull/49#pullrequestreview-113436573, or mute the thread https://github.com/notifications/unsubscribe-auth/AKqS0SG8mMWGJ7ewyubcKTGMukVALzCnks5tp91BgaJpZM4TaBGk .