facebookarchive / shimmer-android

An easy, flexible way to add a shimmering effect to any view in an Android app.
http://facebook.github.io/shimmer-android/
Other
5.32k stars 695 forks source link

Smart quotes in code example #5

Closed jaxbot closed 9 years ago

jaxbot commented 9 years ago

I'll admit this is a pretty dumb ticket, but it's worth pointing out that the code examples on the webpage can't be copy-pasted due to smart quotes used in the code examples:

https://github.com/facebook/shimmer-android/blob/gh-pages/index.html#L95

Pasting this into Android Studio makes the IDE think the wrong closing tags are used, attributes aren't defined, and other totally non-useful errors ;)

Seems like an easy fixed. I'd send over a PR but I think my contract may prevent me from doing so

jasleensingh commented 9 years ago

Thanks, this is fixed!