search

facebookarchive / shimmer-android

An easy, flexible way to add a shimmering effect to any view in an Android app.
http://facebook.github.io/shimmer-android/
Other
5.31k stars 698 forks source link

ShimmerFrameLayout inside ShimmerFrameLayout issue #66

Closed ArturMytsko closed 5 years ago

ArturMytsko commented 5 years ago

In case you have ShimmerFrameLayout (outer) inside ShimmerFrameLayout (inner), and you start shimmer for inner view - it also starts shimmer for outer view (at least animate it). Could you please check this?

xiphirx commented 5 years ago

Are you reusing the same shimmer instance?

ArturMytsko commented 5 years ago

Nope, they are two different instances. I had to do setShimmer() with no visual effects for outer instance in order to overcome this. If you are not able to reproduce it - I can send you example

xiphirx commented 5 years ago

I'll have to check it out, I'll let you know when I do.

xiphirx commented 5 years ago

I just tried this out and I wasn't able to see that starting the inner shimmer caused the outer shimmer to also start. Check that you dont have auto start specified (its on by default) on the outer shimmer.

ArturMytsko commented 5 years ago

Oh.. I've missed the point with auto-start option. Sorry for bothering.