Migrate to AndroidX (and relevant updates)

facebookarchive / shimmer-android

An easy, flexible way to add a shimmering effect to any view in an Android app.

http://facebook.github.io/shimmer-android/

Other

5.32k stars 695 forks source link

Migrate to AndroidX (and relevant updates) #72

Closed mkano9 closed 5 years ago

mkano9 commented 5 years ago

AndroidX migration
Updated targetsdk/compilesdk to 28
Updated gradle wrapper
Updated kotlin to 1.3.10

facebook-github-bot commented 5 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 5 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

mkano9 commented 5 years ago

I'm not familiar with buck, but it seems the buck set up is no longer functional, so I didn't update the buck files.

I also read this description. https://github.com/facebook/shimmer-android/commit/59cd5ef1cfdb11cd2a9b3418cb957eeb25b7e045

mkano9 commented 5 years ago

Hi @xiphirx, it's ready for review. I pushed another commit.

facebook-github-bot commented 5 years ago

@xiphirx merged this pull request in facebook/shimmer-android@cd1148d869e5d240b1299cc2b7a451bb1d557e18.