search

facebookarchive / stetho

Stetho is a debug bridge for Android applications, enabling the powerful Chrome Developer Tools and much more.
http://facebook.github.io/stetho/
MIT License
12.66k stars 1.13k forks source link

Upgrade gradle & android plugin #603

Closed dant3 closed 5 years ago

dant3 commented 6 years ago

I've updated gradle up to 4.4 and android plugin up to 3.1.3 and fixed all corresponding problems. Some observations: I've tried to move to the implementation scope as much as it was possible without breaking stuff for other projects. Most of dependencies are in api scope since it's a safe transition from end-users POV. In reality perhaps some dependencies declarations should be further reworked to be more granular.

facebook-github-bot commented 6 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

dant3 commented 6 years ago

I've signed it

facebook-github-bot commented 6 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

jasta commented 5 years ago

This conflicted with another PR but the effect should now be merged.