search

facebookarchive / stetho

Stetho is a debug bridge for Android applications, enabling the powerful Chrome Developer Tools and much more.
http://facebook.github.io/stetho/
MIT License
12.66k stars 1.13k forks source link

Runtime.getProperties() ignores all requests with "ownProperties":false #611

Closed AlexTrotsenko closed 5 years ago

AlexTrotsenko commented 5 years ago

When Runtime.getProperties() is invoked from the Chrome DevTools with "ownProperties":false this call is ignored and no real value returned.

It's happens because of the explicit check for !request.ownProperties in Runtime.

Any ideas why this is present there? I am working on implementation of Debugger for J2V8, but this code prevents from retrieving values for the local variables when debugger is paused.

I know, that it's 3 years old code and without tests it's hard to understand why it's needed, but may be by the chance @jasta you might know why was it added there?

jasta commented 5 years ago

Unsure if this is still relevant after the merged PRs. Please re-open if this still needs attention.