search

facebookarchive / stetho

Stetho is a debug bridge for Android applications, enabling the powerful Chrome Developer Tools and much more.
http://facebook.github.io/stetho/
MIT License
12.66k stars 1.13k forks source link

Fixing view highlighting on Android P #656

Open shashachu opened 5 years ago

shashachu commented 5 years ago

Fixes https://github.com/facebook/stetho/issues/648

clipOutRect wasn't the proper API to use in this case, so changed to use save and restore.

Based on this SO answer: https://stackoverflow.com/questions/50231950/what-is-the-best-alternative-to-canvas-cliprect-with-region-op-replace/50247323#50247323

facebook-github-bot commented 5 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 5 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

shashachu commented 4 years ago

@jasta is this library still being maintained? Would appreciate this PR getting merged so we can stop using a locally-built stetho version.

obsantos commented 4 years ago

Can this be merged please?