search

facebookarchive / swift

An annotation-based Java library for creating Thrift serializable types and services.
Apache License 2.0
900 stars 297 forks source link

Add command to Swift2Thrift-CLI that allows to specify the namespace for a thrift file in other languages #113

Closed walter-erquinigo closed 11 years ago

walter-erquinigo commented 11 years ago

Done by werquinigo

alandau commented 11 years ago

Thanks, looks good. See the inline comments. Also, you have duplicate commits and a stray merge. Can you create a linear history (one commit or several but no merges; I'll squash all commits when pushing)

walter-erquinigo commented 11 years ago

Hi Alex, I've fixed the errors and squashed everything in a single commit.

alandau commented 11 years ago

Perfect! Will test and commit tomorrow. Thanks!

alandau commented 11 years ago

Merged, thanks