search

facebookarchive / swift

An annotation-based Java library for creating Thrift serializable types and services.
Apache License 2.0
900 stars 297 forks source link

generator does not support unions #119

Closed hgschmie closed 10 years ago

hgschmie commented 11 years ago

Try comping the hive metastore thrift api:

union ColumnStatisticsData { 1: BooleanColumnStatsData booleanStats, 2: LongColumnStatsData longStats, 3: DoubleColumnStatsData doubleStats, 4: StringColumnStatsData stringStats, 5: BinaryColumnStatsData binaryStats }

does not generate any code.

l3fang commented 11 years ago

I have reported this to Andrew roughly half a year ago when I tried the same thing. Luckily in my case I did not need the method that uses the union feature, so I just removed that method in the IDL. But I guess in your case, you need all methods working since you are making a new implementation of metastore...

andrewcox commented 10 years ago

This should be fixed as of 862ffa365b7448cf871303efb7c272fbd86bd62a