search

facebookarchive / swift

An annotation-based Java library for creating Thrift serializable types and services.
Apache License 2.0
900 stars 297 forks source link

Better handling for Thrift namespaces in swift generator #140

Closed andrewcox closed 9 years ago

andrewcox commented 11 years ago

We need to do better handling of namespaces here. I think it would make sense to have identifiers become a 'symbol' when they are first seen, instead of just a string (and have the symbol contain two strings: namespace name, and type name - namespace name would get set to the current filename if there wasn't one parsed explicitly) so that a default namespace is never needed here.

See discussion here https://github.com/andrewcox/swift/commit/8a0b2b5a3a6193afd027ee3d72dc027f77e210fa#commitcomment-4268219 for details

facebook-github-bot commented 9 years ago

Thank you for reaching out to us and we'd like to first apoligize for not getting back to you sooner. We're closing out older issues since updates to the project may address the issue you opened or they may no longer be relevant. If you're still experiencing the problem, please reopen the issue - thanks!