facebookarchive / swift

An annotation-based Java library for creating Thrift serializable types and services.
Apache License 2.0
900 stars 297 forks source link

Need a way to specify a field is optional in swift #162

Closed andrewcox closed 6 years ago

andrewcox commented 10 years ago

@ThriftField annotation could have an "optional" field, and if this is set, the swift->thrift generator should apply the optional attribute to the field.

vener91 commented 10 years ago

ping

allComputableThings commented 9 years ago

Was since added?

/swift/swift-codec/src/test/java/com/facebook/swift/codec/metadata/TestThriftStructMetadataBuilder.java: @ThriftField(value = 1, requiredness = Requiredness.OPTIONAL)

dain commented 9 years ago

@andrewcox is this implemented?

ghost commented 9 years ago

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.