facebookarchive / swift

An annotation-based Java library for creating Thrift serializable types and services.
Apache License 2.0
900 stars 297 forks source link

Fix swift2thrift service generation #212

Closed andrewcox closed 10 years ago

andrewcox commented 10 years ago

This fixes a bug that swift2thrift won't work if you don't explicitly provide a non-UNSPECIFIED requiredness on all @ThriftField annotations on all parameters in your service. Though the @ThriftField annotation default for 'requiredness' is UNSPECIFIED, for a method parameter, this should resolve to NONE.

tsotnet commented 10 years ago

LGTM (y)