ThriftClientManagerConfig needs to provide a way to configure the worker thread count in Netty

facebookarchive / swift

An annotation-based Java library for creating Thrift serializable types and services.

Apache License 2.0

900 stars 297 forks source link

ThriftClientManagerConfig needs to provide a way to configure the worker thread count in Netty #228

Closed l3fang closed 9 years ago

l3fang commented 9 years ago

We have a way to configure the worker thread count for Thrift servers, but not for the client. ThriftClientManagerConfig only allows one to configure the socks proxy address and ThriftClientModule will use the NettyClientConfig object with most default options. This lead to the creation of 64 threads for PTail, which makes less than 10 thrift calls per second.

We need a way to reduce the number of worker thread counts in swift.

scottgoldwater commented 9 years ago

Let me know if I should change something...

l3fang commented 9 years ago

Thanks a lot for the fix!