search

facebookarchive / swift

An annotation-based Java library for creating Thrift serializable types and services.
Apache License 2.0
900 stars 297 forks source link

Benchmarks #236

Closed alandau closed 9 years ago

alandau commented 9 years ago

Serialization benchmarks and a big perf improvement

dain commented 9 years ago

Generally looks good to me, but I'd like to see @martint comments on the benchmark bits as JMH has a lot of knobs.

alandau commented 9 years ago

I think having benchmark results available is very important for perf changes. I don't mind having them in comments on the pull request rather than in the commit message, but I don't think deleting them is the right approach.

martint commented 9 years ago

Standalone benchmark numbers are meaningless, but having a before vs after for a given optimization recorded in the commit message is very useful. It's what I normally do myself: https://github.com/airlift/slice/commit/bc86c85ad72c7b6d6eb49b944136c4bb32144b4a

alandau commented 9 years ago

Thanks for the comments! I need to rethink the benchmarks, I will commit the caching diff though.

alandau commented 9 years ago

Merged the cache diff. Updated benchmarks in this pull request for future reference and closing the pull request without committing them.