Fix swift-maven-plugin integration tests

facebookarchive / swift

An annotation-based Java library for creating Thrift serializable types and services.

Apache License 2.0

900 stars 297 forks source link

Fix swift-maven-plugin integration tests #278

Closed andrewcox closed 8 years ago

andrewcox commented 8 years ago

This test downloads alternate versions of maven to test the plugin against, from a maven repo. Since it was running inside surefire (which for uniform testing purposes tries to provdie a clean environment separate from the user's environment) it was not respecting network properties configured by the user and so the download could fail if you were on an IPv6-only machine, or behind a proxy, etc.

haijunz commented 8 years ago

LGTM. Make sure to test the case when proxyHost and proxyPort is empty

andrewcox commented 8 years ago

I ran 'mvn -U clean verify' on my laptop where none of these settings are needed (and I also verified they aren't set unnecessarily) and the build w/ tests all passed fine.

andrewcox commented 8 years ago

rebased and merged