facebookarchive / swift

An annotation-based Java library for creating Thrift serializable types and services.
Apache License 2.0
900 stars 297 forks source link

Allowing for proper parsing of annotations to have conformity with Apache Thrift #285

Closed skreyen closed 8 years ago

skreyen commented 8 years ago

1) Updated AnnotationTest.thrift to the be latest one from Apache Thrift for the IDL parser. This includes all the supported annotation targets. 2) Copied the file for the generator test as well to increase coverage 3) Updated the Thrift IDL parser to allow for annotations on the items that weren't previously covered, however, those items are ignored past the rewrite rules in the grammar. Therefore, the models don't have to be updated. In the future, should those annotations be needed by Swift for any reason, the grammar can be updated to pass those to the models. In effect, this just makes those annotations be ignored rather than fail the parsing, which is what we want.