search

facebookarchive / swift

An annotation-based Java library for creating Thrift serializable types and services.
Apache License 2.0
900 stars 297 forks source link

Avoid io.airlift.log.Logger and use slf4j #287

Closed Treydone closed 8 years ago

Treydone commented 8 years ago

The logging framework should be configurable and must not rely on the java.util.logging classes. SLF4J is IMHO a best candidate for this.

Classes impacted: com.facebook.swift.service.ThriftServiceProcessor

Files impacted: pom.xml

electrum commented 8 years ago

JUL is built into the JDK and thus is the best choice, especially due to versioning, class loaders, etc. If the application using Swift wants to use SLF4J (or more accurately, a backend for it), then the application may install the bridge from JUL to SLF4J.

electrum commented 8 years ago

We actually used to use SLF4J, but switched to JUL to avoid issues with class loaders: https://github.com/airlift/airlift/commit/5ff3c401da15385f1cab0f54f116a2c12d38f1dd