Inject TransportAttachObserver dependency into ThriftServer

facebookarchive / swift

An annotation-based Java library for creating Thrift serializable types and services.

Apache License 2.0

900 stars 297 forks source link

Inject TransportAttachObserver dependency into ThriftServer #319

Closed ryantimwilson closed 8 years ago

ryantimwilson commented 8 years ago

This allows callers of ThriftServer to specify TransportAttachObserver implementations like nifty's SslConfigFileWatcher to watch files for changes and update the server configuration when they do.

This pull request depends on the nifty 0.22 release. It would be great if we could wait to get this pull request in for the swift 0.22 release as well.

ryantimwilson commented 8 years ago

@ivmaykov I've added a DummyTransportAttachObserver test (sets boolean variable to true on attach / false on detach).

siyengar commented 8 years ago

lgtm