search

facebookarchive / swift

An annotation-based Java library for creating Thrift serializable types and services.
Apache License 2.0
900 stars 297 forks source link

remove the exception for null result #344

Closed saoxuequ closed 6 years ago

saoxuequ commented 7 years ago

I think the return value is null should not be an exception, because sometimes we have to do it.So why do we have to catch the exception to make sure the return value is null?(Swift works for Java, isn't it?)

facebook-github-bot commented 7 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

saoxuequ commented 7 years ago

@facebook-github-bot Signed.

facebook-github-bot commented 7 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

erikonad commented 7 years ago

I agree, this would be a good patch.