search

facebookarchive / swift

An annotation-based Java library for creating Thrift serializable types and services.
Apache License 2.0
900 stars 297 forks source link

ThriftClientManager.createClient swallows exceptions #79

Closed electrum closed 11 years ago

electrum commented 11 years ago

There is a bug here:

https://github.com/facebook/swift/blob/master/swift-service/src/main/java/com/facebook/swift/service/ThriftClientManager.java#L138

The future needs to be set with any exception thrown by createClient(). Currently, an exception there causes the future to never be set.

I ran into this by having a @ThriftService method that threw multiple exceptions but didn't declare them in the @ThriftMethod annotation.

andrewcox commented 11 years ago

This has been fixed in the above-referenced commit