search

facebookarchive / swift

An annotation-based Java library for creating Thrift serializable types and services.
Apache License 2.0
900 stars 297 forks source link

Expose TStruct object when reading Thrift input stream #97

Closed hgschmie closed 11 years ago

hgschmie commented 11 years ago

To be able to replay an incoming data stream, the TStruct information must be visible. Change the readStructBegin() method on the TProtocolReader to expose this information.

dain commented 11 years ago

Looks good to me

hgschmie commented 11 years ago

I would like to have @andrewcox take a longer look at this as it changes the signature of a public method on TProtocolReader and that might break backwards compatibility.

andrewcox commented 11 years ago

Again, no real problem with the code here. But the TStruct is really a placeholder with no data for most thrift messages.