facebookarchive / xctool

An extension for Apple's xcodebuild that makes it easier to test iOS and macOS apps.
Apache License 2.0
6.91k stars 738 forks source link

Use xcodebuild directly when on Xcode 8 #712

Closed dinhvh closed 8 years ago

dinhvh commented 8 years ago

On Xcode 8, we'll just pass-through the output and check the error code of xcodebuild.

ExtremeMan commented 8 years ago

Hm. Do you say xcodebuild-shim doesn't work at all in Xcode 8?

dinhvh commented 8 years ago

To link dynamically against xcodebuild, we need to have a binary signed with certificate of Apple. (It's complaining about Developer Team ID)

dinhvh commented 8 years ago

The build & tests passed!

oliverhu commented 8 years ago

+1 Yah, we have to remove xcodebuild-shim in Xcode 8.

ExtremeMan commented 8 years ago

fprintf(stdout, "%s\n", [line UTF8String]);

I don't like this at all =( This will break most of CIs which rely on custom reporters, for example. Let's better assert there and let users know why it is done and how to resolve the issue.

ExtremeMan commented 8 years ago

Another alternative is to use new -json option of xcodebuild, parse results in xctool and reformat for our own reporters format. But I think we should just stop supporting build features in xctool.