search

facebookarchive / xctool

An extension for Apple's xcodebuild that makes it easier to test iOS and macOS apps.
Apache License 2.0
6.91k stars 738 forks source link

Fix simulator SDK not found in Xcode 8.3.3 #733

Closed ProfessaA closed 7 years ago

ProfessaA commented 7 years ago

background After upgrading to Xcode 8.3.3, xctool would fail when targeting simulators with "Unable to find SDK for platform iphonesimulator and sdk version 10.3.1", even though the 10.3 sdk was installed.

This issue is caused by -[SimRuntime versionString] including the patch version of the sdk, while the sdk's SDKSettings.plist includes only the major and minor version.

change When comparing the version as reported by SimRuntime to the versions pulled from the sdk's plist, ignore the patch version.

verification

ExtremeMan commented 7 years ago

I need to figure out why CI is broken.

ExtremeMan commented 7 years ago

I've update CI script and indeed xctool test fails under Xcode 8.3.3. I've pushed some changes and retested your PR on top of them. Everything is now green. Thanks for a PR!

zayhero-zz commented 7 years ago

@ProfessaA Thanks a lot for the PR! @ExtremeMan Are you going to public a new release version for this change?

ExtremeMan commented 7 years ago

@zayhero I will make a release. Give me some time.