search

facebookarchive / xctool

An extension for Apple's xcodebuild that makes it easier to test iOS and macOS apps.
Apache License 2.0
6.91k stars 738 forks source link

Update for Xcode 10 compatibility and fix hardcoded search path in otest-query-appletv target #753

Closed alanzeino closed 6 years ago

alanzeino commented 6 years ago

Fixes #752

alanzeino commented 6 years ago

I can update this @ExtremeMan — the PR in #755 was one part, we also need this PR as well

ExtremeMan commented 6 years ago

Looks like tests are timing out.

ExtremeMan commented 6 years ago

Ooops, saw your comment after posting mine. Let me know if you need help. I might try it out too.

alanzeino commented 6 years ago

Yeah there was something I had to fix that I remember from when I put the PR up. Taking a look now.

alanzeino commented 6 years ago

Looks like OTestShimTests are failing. xctool might not be showing these failures well but I can see them in Xcode:

UI Test Activity: 
Assertion Failure: OTestShimTests.m:275: Expected a dictionary containing key "test", but was nil

UI Test Activity: 
Assertion Failure: OTestShimTests.m:276: Expected "-[XCTest_Assertion testExpectedAssertionIsSilent]", but was nil

UI Test Activity: 
Assertion Failure: OTestShimTests.m:280: Expected a string containing "[GOOD1]", but was "An error was encountered processing the command (domain=com.apple.CoreSimulator.LaunchdSimError, code=111):\n"
alanzeino commented 6 years ago

So in my testing, these tests don't work with Xcode 9.4 either. I think the last supported Xcode version was 9.2?

ExtremeMan commented 6 years ago

Oh, really? Travis is using 9.3

alanzeino commented 6 years ago

Yep you're correct. Looks like we need to bump it to 9.4 first? I tried tackling it but I'm lacking project context to fix that one :)

ExtremeMan commented 6 years ago

I have pushed several commits similar to what you proposed! Thanks for your PR. Take a look if xctool needs more fixing but overall I feel it should work now on Xcode 10

ExtremeMan commented 6 years ago

Travis is still flaky though :( will be looking into it later

alanzeino commented 6 years ago

Should I rebase so we can land the issue where otest-query-appletv is using an absolute path? I bundled that into this PR as well.

ExtremeMan commented 6 years ago

Oh, I missed that piece. Can you rebase?

alanzeino commented 6 years ago

Updated!

ExtremeMan commented 6 years ago

Thanks a lot for pushing to fix xctool for Xcode 10 and providing fixes!