search

facebookexperimental / Recoil

Recoil is an experimental state management library for React apps. It provides several capabilities that are difficult to achieve with React alone, while being compatible with the newest features of React.
https://recoiljs.org/
MIT License
19.59k stars 1.18k forks source link

Fix: Snapshot has already been released (#1994) #2243

Closed cjvnjde closed 9 months ago

cjvnjde commented 1 year ago

Summary: This pull request addresses an issue regarding the functioning of setTimeout in Firefox, which behaves slightly differently from Chrome. The previous solution utilized a setTimeout delay of 10ms, but after conducting tests, I discovered that nested timeouts provide a more optimal approach, eliminating crashes and improving compatibility with Firefox.

Fixes: https://github.com/facebookexperimental/Recoil/issues/1994

facebook-github-bot commented 1 year ago

Hi @cjvnjde!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 1 year ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!