search

facebookexperimental / Robyn

Robyn is an experimental, AI/ML-powered and open sourced Marketing Mix Modeling (MMM) package from Meta Marketing Science. Our mission is to democratise modeling knowledge, inspire the industry through innovation, reduce human bias in the modeling process & build a strong open source marketing science community.
https://facebookexperimental.github.io/Robyn/
MIT License
1.16k stars 344 forks source link

unit tests for response curve #1100

Closed Marco-Premier closed 3 weeks ago

Marco-Premier commented 3 weeks ago

Project Robyn

Add Unit Tests for response_curve pareto method

Fixes # (issue)

Fix this line: metric_loc = slice(end_rw - n_periods + 1, end_rw) to metric_loc = slice(end_rw - n_periods, end_rw + 1)

eg, date range is:

[1,2,3,4,5]

rolling_window_start_which = 1 rolling_window_end_which = 5

slice(1,5) would return [1,2,3,4] and not [1,2,3,4,5]

Marco-Premier commented 3 weeks ago

Closing this as it won't run tests automatically as it checkout main