search

facebookexperimental / Robyn

Robyn is an experimental, AI/ML-powered and open sourced Marketing Mix Modeling (MMM) package from Meta Marketing Science. Our mission is to democratise modeling knowledge, inspire the industry through innovation, reduce human bias in the modeling process & build a strong open source marketing science community.
https://facebookexperimental.github.io/Robyn/
MIT License
1.15k stars 343 forks source link

New upgrade to 3.8 giving error in robyn_inputs #520

Closed virithavanama closed 1 year ago

virithavanama commented 2 years ago

Hi Team,

I have upgraded to the new Robyn 3.8 version and getting the below error:

Screen Shot 2022-10-28 at 9 30 11 AM
laresbernardo commented 2 years ago

Thanks for reporting this bug @virithavanama I've updated main branch, can you please update and re-try?

virithavanama commented 2 years ago

Thanks, @laresbernardo for the prompt fix :) Now I get a new issue when running robyn_run:

Screen Shot 2022-10-28 at 11 26 56 AM
laresbernardo commented 2 years ago

Can you please share a reproducible example as I can't seem to be able to reproduce this one?

DpfStat commented 2 years ago

Same issue with 3.8.0 for running robyn_run. If use the same data set with 3.7.2, no error.

firatfrkn commented 2 years ago

The same issue I am having Screenshot 2022-11-01 112633

gufengzhou commented 2 years ago

We can't reproduce the same error. Could you please share an anonymised dataset for us to debug. thanks

gufengzhou commented 2 years ago

@firatfrkn Thanks for providing the anonymous dataset for debugging. I've just pushed the fix. It runs now on my side. Can you please update the package and check.

firatfrkn commented 2 years ago

thanks a lot. It works for me now

gufengzhou commented 2 years ago

cool thanks for confirming. you can check the fix detail in the commit here

AruunnAnanda commented 2 years ago

@gufengzhou I still have the same problem after updating to v3.8.1. To update I ran the command - Robyn::robyn_update() image

gufengzhou commented 2 years ago

strange. have you checked packageVersion("Robyn") that's v3.8.1 and restarted the R session? If it's still there, I'd need an anonymous dataset from to you debug.

AruunnAnanda commented 2 years ago

@gufengzhou Yes, I did.

This time the error is - Error in {: task 1 failed - "non-numeric argument to binary operator"

This error is different than the last time. I'm attaching the last time error here.

image

gufengzhou commented 2 years ago

Please provide your dataset anonymised and your model specification in robyn_inputs() and hyperparameters for debugging. you can send it to gufeng@meta.com

gufengzhou commented 2 years ago

Hey @AruunnAnanda , I managed to reproduce your error and just pushed a fix. Could you please update and retest. thanks

AruunnAnanda commented 2 years ago

Hey @gufengzhou, I unfortunately still have the same error.

If I don't use calibration as an input the model RUNS FINE.

If I start using calibration as an input the model throws an error

gufengzhou commented 2 years ago

ok that's an important information missing that you used calibration. I'll check and get back.

gufengzhou commented 2 years ago

@AruunnAnanda Please update and check

AruunnAnanda commented 2 years ago

@gufengzhou I still have the same issue :(

I sent you the anonymised data via email to replicate and debug.

gufengzhou commented 2 years ago

thanks for the data. I've just pushed another fix and it runs on my macbook. please update and try

virithavanama commented 2 years ago

Thanks for the bug fixes. robyn_inputs issue is fixed for me too! But now having an issue with robyn_outputs:

image
gufengzhou commented 2 years ago

there's been some fixes since then. can you update the package incl. dependencies, restart R and retry please?

gufengzhou commented 2 years ago

This should be fixed with the latest commits. Please update and check

gufengzhou commented 1 year ago

Please reopen if issue reoccurs.