facebookexperimental / Robyn

Robyn is an experimental, AI/ML-powered and open sourced Marketing Mix Modeling (MMM) package from Meta Marketing Science. Our mission is to democratise modeling knowledge, inspire the industry through innovation, reduce human bias in the modeling process & build a strong open source marketing science community.
https://facebookexperimental.github.io/Robyn/
MIT License
1.08k stars 322 forks source link

Fix React warnings/errors. #831

Closed zpao closed 9 months ago

zpao commented 9 months ago

This fixes warnings/errors that React is outputting.

  1. title was an object, so the same key was being set for all elements. There's no need to use JSX for that since you're rendering an <h3> anyway, so easy win.
  2. <ul> isn't a valid DOM child of <p> so rendering engines actually move DOM nodes around to make it work, which can break React. Use a <div> instead (and remove extra React fragment wrapping).
  3. Properly case some attributes on <iframe>s