search

facebookexperimental / Robyn

Robyn is an experimental, AI/ML-powered and open sourced Marketing Mix Modeling (MMM) package from Meta Marketing Science. Our mission is to democratise modeling knowledge, inspire the industry through innovation, reduce human bias in the modeling process & build a strong open source marketing science community.
https://facebookexperimental.github.io/Robyn/
MIT License
1.08k stars 322 forks source link

Weibull adstock graph problem #877

Closed AdimDrewnik closed 7 months ago

AdimDrewnik commented 7 months ago

When using Weibull adstock the graphical output is problematic and borderline useless. For example assume that someone uses few years of daily data and has 10-20 channels. In that case Weibull part of results is so compressed on the graph that nothing useful can be seen. Also why does x axis on this graphs span the range of the whole data set? If I analyse 3 years of daily data why do I need almost 1000 days on x axis?

Graphical results for Weibull adstock should be presented on a separate page. If there are many channels graphs need to be split across multiple pages, e.g. 10 channels per page.

In case of Weibull pdf adstock showing half life probably makes no sense. Maybe indicating peak is more informative.

gufengzhou commented 7 months ago

"Borderline useless" is very passive aggressive language.

AdimDrewnik commented 7 months ago

"Borderline useless" is very passive aggressive language.

Sorry for that, I am not a native speaker so I am not always aware of how my opinions would be taken by native speakers.

AdimDrewnik commented 7 months ago

Why this issue was closed? Was I incorrect in my description of the problem? Right now using Weibull pdf is a huge pain when it comes to interpretation of the results.