facebookexperimental / Robyn

Robyn is an experimental, AI/ML-powered and open sourced Marketing Mix Modeling (MMM) package from Meta Marketing Science. Our mission is to democratise modeling knowledge, inspire the industry through innovation, reduce human bias in the modeling process & build a strong open source marketing science community.
https://facebookexperimental.github.io/Robyn/
MIT License
1.07k stars 322 forks source link

Unable to recreate model or refresh using JSON #948

Open jaylin1 opened 3 months ago

jaylin1 commented 3 months ago

Hi Robyn team,

I'm trying to refresh a model I created using an older version of Robyn. I've tried rerunning the model that created it initially and it gives me an error. I'm using weibull pdf and I've noticed I cannot set channel scales and shapes to 0 which previously worked on "version": ["Robyn (stable) v3.9.0 [R-4.2.2]"]. The model runs after changing the bounds to non-zero. Was there a change made to this? What changes do I need to make to recreate this model so I can refresh it? My goal is to keep the results from the previous year consistent and to refresh on a new year of data.

This is the error I get when I try to run the refresh function on the json:

Error in { : task 1 failed - "'names' attribute [8] must be the same length as the vector [5]"

image image

Current environment: R version 4.3.0 (2023-04-21 ucrt) Platform: x86_64-w64-mingw32/x64 (64-bit) Running under: Windows 10 x64 (build 19045) Robyn_3.10.3

@gufengzhou

jaylin1 commented 3 months ago

In an attempt to get it to refresh, I changed the shapes lower and upper bound to 0.0001 and got past this error. The next problem I'm facing is inspecting the values in the json vs what is read into R, the xDecompAgg results are different from what's in the json. the model is recreated, and data is ingested through the robyn_recreate function. Can you please provide guidance on how I can address either or both problems I've mentioned? Thanks in advance.

gufengzhou commented 2 months ago

Hi sorry for the late reply. Both issues (allowing 0 shape/scale and robyn_recreate) should be fixed with the latest GitHub version. Can you update and try?