Open tyroguru opened 11 months ago
Attention: 5 lines
in your changes are missing coverage. Please review.
Comparison is base (
9e2b48d
) 68.70% compared to head (86e97e7
) 68.68%. Report is 1 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
oi/type_graph/DrgnParser.cpp | 0.00% | 5 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'm wondering if this change makes total sense - we're taking in a function type which is explicitly unsized, and stating that it's a sized type StubbedPointer
. I wonder if it would make more sense to immediately return an Incomplete
from this switch case, along with a depth decrement. That would work if the goal is to prevent hitting the catch
statement. I could be missing something though!
I wrote this bit of code which I think neatens up the depth decrement, if we do decrement in this specific switch case it would make sense to use something like this: https://github.com/JakeHillion/object-introspection/blob/6be7e7708bfd69c75faa46d42df81a79734eab46/oi/type_graph/ClangTypeParser.cpp#L45-L55
Finding a test case for this proved difficult. Putting this on hold until we hit this issue in production again.
Summary
Handle function types when enumerating types.
Test plan
A test needs adding.