clangparser: mark incomplete arrays as incomplete without failing

facebookexperimental / object-introspection

Object Introspection (OI) enables on-demand, hierarchical profiling of objects in arbitrary C/C++ programs with no recompilation.

Apache License 2.0

160 stars 13 forks source link

clangparser: mark incomplete arrays as incomplete without failing #441

Closed JakeHillion closed 9 months ago

JakeHillion commented 9 months ago

clangparser: mark incomplete arrays as incomplete without failing

Attempting to complete a type which can't be completed currently fails oilgen. For incomplete arrays, which we know are not possible to complete, return false deliberately.

requireCompleteType likely needs to not fail in all cases in the future. For now this works.

Test plan:

std::unique_ptr<long[]> used to fail the generation. Now it can successfully codegen.