Closed JakeHillion closed 9 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
4c047b5
) 62.44% compared to head (1e7e8ff
) 62.44%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
test: add features field to integration tests
Previously we tested different feature flags by using the
cli_options
field in the test.toml
. This works for OID but doesn't work for JIT OIL and won't work for AoT OIL when those tests get added.This change adds a new higher level
features
field to the test.toml
which adds the features to the config file as a prefix. This works with all methods of generation.Change the existing
cli_options
features tofeatures
except for where they're testing something specific. Enable tests that were previously disabled for OIL but only didn't work because of not being able to enable features. Change pointer tests that are currently broken for OIL fromoil_disable
tooil_skip
- they can work, but codegen is broken for them at the minute.Test plan:
make test
is no worseStack created with Sapling. Best reviewed with ReviewStack.
462