facebookexperimental / object-introspection

Object Introspection (OI) enables on-demand, hierarchical profiling of objects in arbitrary C/C++ programs with no recompilation.
Apache License 2.0
163 stars 14 forks source link

test: add features field to integration tests #460

Closed JakeHillion closed 9 months ago

JakeHillion commented 9 months ago

test: add features field to integration tests

Previously we tested different feature flags by using the cli_options field in the test .toml. This works for OID but doesn't work for JIT OIL and won't work for AoT OIL when those tests get added.

This change adds a new higher level features field to the test .toml which adds the features to the config file as a prefix. This works with all methods of generation.

Change the existing cli_options features to features except for where they're testing something specific. Enable tests that were previously disabled for OIL but only didn't work because of not being able to enable features. Change pointer tests that are currently broken for OIL from oil_disable to oil_skip - they can work, but codegen is broken for them at the minute.

Test plan:


Stack created with Sapling. Best reviewed with ReviewStack.

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4c047b5) 62.44% compared to head (1e7e8ff) 62.44%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #460 +/- ## ======================================= Coverage 62.44% 62.44% ======================================= Files 123 123 Lines 12021 12021 Branches 1958 1958 ======================================= Hits 7507 7507 Misses 3569 3569 Partials 945 945 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.