Closed JakeHillion closed 8 months ago
Attention: 21 lines
in your changes are missing coverage. Please review.
Comparison is base (
4975b6e
) 62.44% compared to head (351f2f8
) 62.41%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
tbv2: support capture-thrift-isset
Support the capture-thrift-isset feature with TreeBuilder-v2. Fairly minor changes here except the type of the Enum in a template parameter now matters.
We follow the previous behaviour of capturing a value for each field in a struct that has an
isset_bitset
. This value is a VarInt captured before the C++ contents of the member. It has 3 values: 0 (not set), 1 (set), and 2 (unavailable). These are handled by the processor and represented in the output asfalse
,true
, andstd::nullopt_t
respectively.Changes:
IssetBitsetOption
. This could turn out to be wrong.Test plan:
FILTER='OilIntegration.*' make test
- Thrift tests failed before, succeed after.