facebookexperimental / object-introspection

Object Introspection (OI) enables on-demand, hierarchical profiling of objects in arbitrary C/C++ programs with no recompilation.
Apache License 2.0
160 stars 13 forks source link

tbv2: fix thrift isset with ClangTypeParser #463

Closed JakeHillion closed 8 months ago

JakeHillion commented 8 months ago

tbv2: fix thrift isset with ClangTypeParser

Some of the logic that makes Thrift isset work for TreeBuilder-v2 in DrgnParser (JIT OIL) wasn't ported to ClangTypeParser meaning it doesn't work in Ahead-of-Time (AoT) OIL.

Add the template parameter name reconstruction for enum values to ClangTypeParser.

Test plan:

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (40af807) 62.42% compared to head (d47fae1) 62.42%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #463 +/- ## ======================================= Coverage 62.42% 62.42% ======================================= Files 123 123 Lines 12054 12054 Branches 1965 1965 ======================================= Hits 7525 7525 Misses 3577 3577 Partials 952 952 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.