Closed JakeHillion closed 9 months ago
This pull request was exported from Phabricator. Differential Revision: D53002752
This pull request was exported from Phabricator. Differential Revision: D53002752
Attention: Patch coverage is 96.00000%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 62.50%. Comparing base (
7de3586
) to head (978352a
). Report is 45 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
oi/OICodeGen.cpp | 0.00% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request was exported from Phabricator. Differential Revision: D53002752
This pull request was exported from Phabricator. Differential Revision: D53002752
This pull request was exported from Phabricator. Differential Revision: D53002752
Summary: OI was previously using
std::regex_match
to match container names. This was bad becauselibstdc++
's implementation of regex is awful. In the case of limited inlining it was causing a stack overflow when running CodeGen for large types (I think types with large names but I never got to the bottom of it).Replace this with the competent
boost::regex_match
that we already have a dependency on.Differential Revision: D53002752