facebookexperimental / object-introspection

Object Introspection (OI) enables on-demand, hierarchical profiling of objects in arbitrary C/C++ programs with no recompilation.
Apache License 2.0
163 stars 14 forks source link

container_info: switch to boost::regex #465

Closed JakeHillion closed 9 months ago

JakeHillion commented 9 months ago

Summary: OI was previously using std::regex_match to match container names. This was bad because libstdc++'s implementation of regex is awful. In the case of limited inlining it was causing a stack overflow when running CodeGen for large types (I think types with large names but I never got to the bottom of it).

Replace this with the competent boost::regex_match that we already have a dependency on.

Differential Revision: D53002752

facebook-github-bot commented 9 months ago

This pull request was exported from Phabricator. Differential Revision: D53002752

facebook-github-bot commented 9 months ago

This pull request was exported from Phabricator. Differential Revision: D53002752

codecov-commenter commented 9 months ago

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.50%. Comparing base (7de3586) to head (978352a). Report is 45 commits behind head on main.

Files with missing lines Patch % Lines
oi/OICodeGen.cpp 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #465 +/- ## ========================================== + Coverage 62.49% 62.50% +0.01% ========================================== Files 123 123 Lines 12070 12072 +2 Branches 1966 1966 ========================================== + Hits 7543 7546 +3 + Misses 3572 3571 -1 Partials 955 955 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

facebook-github-bot commented 9 months ago

This pull request was exported from Phabricator. Differential Revision: D53002752

facebook-github-bot commented 9 months ago

This pull request was exported from Phabricator. Differential Revision: D53002752

facebook-github-bot commented 9 months ago

This pull request was exported from Phabricator. Differential Revision: D53002752