Closed tyroguru closed 9 months ago
Attention: 7 lines
in your changes are missing coverage. Please review.
Comparison is base (
b5b94ed
) 62.51% compared to head (56be62e
) 62.52%. Report is 4 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
oi/type_graph/Types.h | 70.00% | 3 Missing :warning: |
oi/CodeGen.cpp | 71.42% | 1 Missing and 1 partial :warning: |
oi/type_graph/Visitor.h | 50.00% | 1 Missing :warning: |
test/test_key_capture.cpp | 83.33% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Summary
If a map in an object is typedef'd then we fail to identify the map as a container and ignore it as the target for key capture.
e.g.
Currently the following config with the above definition would fail to capture keys in maMap:
Test plan
I've added a new integration test 'capture_keys_typedef' and a unit test.
There are more changes here than first thought needed but the reviewers ar well aware :-) .