search

facebookexperimental / object-introspection

Object Introspection (OI) enables on-demand, hierarchical profiling of objects in arbitrary C/C++ programs with no recompilation.
Apache License 2.0
163 stars 14 forks source link

convert circleci workflow to github actions #481

Open robandpdx opened 8 months ago

robandpdx commented 8 months ago

Summary

This pull request converts the CircleCI workflows to GitHub actions workflows. Notes

When trying to install the dependencies for the build job, I see the following error: Error

Some packages could not be installed. This may mean that you have requested an impossible situation or if you are using the unstable distribution that some required packages have not yet been created or been moved out of Incoming. The following information may help to resolve the situation:

The following packages have unmet dependencies: libgoogle-glog-dev : Depends: libunwind-dev or libunwind7-dev but it is not installable E: Unable to correct problems, you have held broken packages. Error: Process completed with exit code 100.

This error does not occur when running the build job inside the ubuntu:22.04 container image.

The test job fails with errors too large to list here. Here is a link to the logs of a recent workflow run.

The coverage job was not tested becuase it depends on the failing test job. There should be a repo secret called CODECOV_TOKEN defined.

https://fburl.com/workplace/f6mz6tmw

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7103680) 62.71% compared to head (653b6f8) 62.71%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #481 +/- ## ======================================= Coverage 62.71% 62.71% ======================================= Files 123 123 Lines 12100 12100 Branches 1971 1971 ======================================= Hits 7589 7589 Misses 3555 3555 Partials 956 956 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JakeHillion commented 8 months ago

Hi @robandpdx, thanks for starting this migration! A couple of questions:

  1. I approved the CI runs yesterday on this PR and the new build jobs have been queued for ~14 hours. What's going on here?
  2. Given you've detailed the build job as failing, this clearly doesn't have feature parity with our existing CircleCI config. What are the next steps to make this work?

Thanks!

ajor commented 8 months ago

It looks like the test failures are due to the missing dependencies from the build job. They're all failing with this message:

error while loading shared libraries: libunwind.so.8: cannot open shared object file: No such file or directory
robandpdx commented 8 months ago

What are the next steps to make this work?

Someone with better knowledge of the project should probably take it from here. I'm happy to help also if someone can provide me some direction on how to resolve the errors.

JakeHillion commented 8 months ago

Just made a total mess of this PR... That'll teach me for using a WIP Git client. Should be mostly back now except for messing up the formatting in the description.

I've wanted to make a change to the linting check for a while so I've done that with GitHub actions in #488 as it seems to work fine. I'm not sure how to debug the other workflows at the minute as it's not possible to get into a running machine like it was with CircleCI, but at least this is a start.