search

facebookexperimental / object-introspection

Object Introspection (OI) enables on-demand, hierarchical profiling of objects in arbitrary C/C++ programs with no recompilation.
Apache License 2.0
160 stars 13 forks source link

remove internal build config and update for CentOS 9 #482

Closed JakeHillion closed 6 months ago

JakeHillion commented 7 months ago

remove internal build config and update for CentOS 9

Previously we maintained three types of builds: a fully internal BUCK build, a CMake build with modifications to use things from an internal toolchain, and an open source CMake build.

As far as I'm concerned the intermediate build is not useful because our source is readily available in both an internal and external form. Use cases as follows:

  1. BUCK build for distributing widely.
  2. BUCK build for getting a static binary that can be run on any machine.
  3. CMake build for primary development.
  4. CMake build for external CI.

With the internal update to CentOS Stream 9 an unmodified CMake build now works readily. This change patches up some things that were relying on system headers that should have been vendored and cleans up drgn dependencies.

Test plan:

Stack created with Sapling. Best reviewed with ReviewStack.

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7e18c4c) 62.70% compared to head (d1b62bc) 62.70%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #482 +/- ## ======================================= Coverage 62.70% 62.70% ======================================= Files 123 123 Lines 12097 12097 Branches 1970 1970 ======================================= Hits 7586 7586 Misses 3556 3556 Partials 955 955 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JakeHillion commented 6 months ago

Closing this PR as it mainly affects the internal devserver build. Given I'll be unable to follow up if I mess it up I'll have to leave this work for someone else to do down the line - feel free to pick it up in future.