Closed tyroguru closed 4 months ago
A list of clang supported attributes can be found at https://releases.llvm.org/9.0.0/tools/clang/docs/AttributeReference.html . It appears to me that we don't need to do anything special at all with any directive w.r.t what we do in OI. All I have done here is to extract the "minimally-desugared" type as described in https://clang.llvm.org/doxygen/classclang_1_1AttributedType.html .
No new test failures were encountered with a make test. This was tested against a Meta internal application that uses the folly FOLLY_NONNULL directive.
make test
FOLLY_NONNULL
Summary
A list of clang supported attributes can be found at https://releases.llvm.org/9.0.0/tools/clang/docs/AttributeReference.html . It appears to me that we don't need to do anything special at all with any directive w.r.t what we do in OI. All I have done here is to extract the "minimally-desugared" type as described in https://clang.llvm.org/doxygen/classclang_1_1AttributedType.html .
Test plan
No new test failures were encountered with a
make test
. This was tested against a Meta internal application that uses the follyFOLLY_NONNULL
directive.