search

facebookexperimental / object-introspection

Object Introspection (OI) enables on-demand, hierarchical profiling of objects in arbitrary C/C++ programs with no recompilation.
Apache License 2.0
160 stars 13 forks source link

Adjust object-introspection to llvm-18 API changes #506

Closed MatzeB closed 3 weeks ago

MatzeB commented 3 weeks ago

Summary: LLVM-18 changed the CompilerInvocation APIs to return references instead of pointers...

Differential Revision: D61548431

facebook-github-bot commented 3 weeks ago

This pull request was exported from Phabricator. Differential Revision: D61548431

codecov-commenter commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.79%. Comparing base (fe9b4b2) to head (9eaf79b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #506 +/- ## ========================================== - Coverage 60.79% 60.79% -0.01% ========================================== Files 126 126 Lines 12491 12493 +2 Branches 2014 2014 ========================================== + Hits 7594 7595 +1 - Misses 3940 3941 +1 Partials 957 957 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

facebook-github-bot commented 3 weeks ago

This pull request was exported from Phabricator. Differential Revision: D61548431

facebook-github-bot commented 3 weeks ago

This pull request was exported from Phabricator. Differential Revision: D61548431

MatzeB commented 3 weeks ago

Not sure why this test job failed. Seems unrelated to the changes.

JakeHillion commented 3 weeks ago

Not sure why this test job failed. Seems unrelated to the changes.

How strange, that CI job isn't usually flaky. I restarted it and you're good to land this in Phabricator now.