Closed JakeHillion closed 3 weeks ago
This pull request was exported from Phabricator. Differential Revision: D61661524
Attention: Patch coverage is 54.54545%
with 5 lines
in your changes missing coverage. Please review.
Project coverage is 60.79%. Comparing base (
8831269
) to head (c70d6b2
).
Files | Patch % | Lines |
---|---|---|
oi/Descs.h | 0.00% | 2 Missing :warning: |
oi/arch/x86_64.cpp | 60.00% | 2 Missing :warning: |
oi/Descs.cpp | 66.66% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request was exported from Phabricator. Differential Revision: D61661524
This pull request was exported from Phabricator. Differential Revision: D61661524
Summary: OI is currently completely incompatible with anything except
x86_64
. Changing that generally is a big effort, butoilgen
should work on other architectures. Begin adding some support foraarch64
architecture.This change sets up a file structure for architecture support. It pulls the 2 functions needed to make
Descs.{h,cpp}
architecture agnostic into architecture specific files forx86_64
andaarch64
. This enablesoilgen
(the binary) to build. At this stageoilgen
is unable to generate working code foraarch64
, but at least this is a step in the right direction.Differential Revision: D61661524