search

facebookincubator / Battery-Metrics

Library that helps in instrumenting battery related system metrics.
MIT License
745 stars 79 forks source link

Synthetic accessors need to be removed. #8

Closed VisheshVadhera closed 7 years ago

VisheshVadhera commented 7 years ago

There are right now 23 synthetic accessor methods in metrics module, which need to be removed in order to reduce the count of methods in the dex file.

kunalb commented 7 years ago

Thanks for catching that! We've been using redex (http://fbredex.com/) so I never payed attention to that. Would you be interested in creating a diff for this as well or should I fix it?

VisheshVadhera commented 7 years ago

I'll tackle this one. I'll submit a PR soon.

On Nov 23, 2017 4:50 AM, "Kunal Bhalla" notifications@github.com wrote:

Thanks for catching that! We've been using redex (http://fbredex.com/) so I never payed attention to that. Would you be interested in creating a diff for this as well or should I fix it?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/facebookincubator/Battery-Metrics/issues/8#issuecomment-346498921, or mute the thread https://github.com/notifications/unsubscribe-auth/AD1DEP8k_KqvxtcFpRjE2T65C3LhRSJ5ks5s5Kw6gaJpZM4QmX6v .